diff --git a/CHANGELOG.md b/CHANGELOG.md index 33aab2a233..642a7afbda 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,10 @@ Please add one entry in this file for each change in Yarn's behavior. Use the sa [#6983](https://github.com/yarnpkg/yarn/pull/6983) - [**Micha Reiser**](https://github.com/MichaReiser) +- Run the engines check before executing `run` scripts. + + [#7013](https://github.com/yarnpkg/yarn/issues/7013) - [**Eloy DurĂ¡n**](https://github.com/alloy) + ## 1.14.0 - Improves PnP compatibility with Node 6 diff --git a/src/cli/commands/run.js b/src/cli/commands/run.js index 66fbaaff09..f2c2a4a75a 100644 --- a/src/cli/commands/run.js +++ b/src/cli/commands/run.js @@ -6,6 +6,7 @@ import {execCommand, makeEnv} from '../../util/execute-lifecycle-script.js'; import {dynamicRequire} from '../../util/dynamic-require.js'; import {MessageError} from '../../errors.js'; import {registries} from '../../resolvers/index.js'; +import {checkOne as checkCompatibility} from '../../package-compatibility.js'; import * as fs from '../../util/fs.js'; import * as constants from '../../constants.js'; @@ -118,6 +119,13 @@ export async function run(config: Config, reporter: Reporter, flags: Object, arg } if (cmds.length) { + const ignoreEngines = !!(flags.ignoreEngines || config.getOption('ignore-engines')); + try { + await checkCompatibility({_reference: {}, ...pkg}, config, ignoreEngines); + } catch (err) { + throw err instanceof MessageError ? new MessageError(reporter.lang('cannotRunWithIncompatibleEnv')) : err; + } + // Disable wrapper in executed commands process.env.YARN_WRAP_OUTPUT = 'false'; for (const [stage, cmd] of cmds) { diff --git a/src/reporters/lang/en.js b/src/reporters/lang/en.js index fdd512fdd6..816446cdfd 100644 --- a/src/reporters/lang/en.js +++ b/src/reporters/lang/en.js @@ -229,11 +229,12 @@ const messages = { nodeGypAutoInstallFailed: 'Failed to auto-install node-gyp. Please run "yarn global add node-gyp" manually. Error: $0', - foundIncompatible: 'Found incompatible module', + foundIncompatible: 'Found incompatible module.', incompatibleEngine: 'The engine $0 is incompatible with this module. Expected version $1. Got $2', incompatibleCPU: 'The CPU architecture $0 is incompatible with this module.', incompatibleOS: 'The platform $0 is incompatible with this module.', invalidEngine: 'The engine $0 appears to be invalid.', + cannotRunWithIncompatibleEnv: 'Commands cannot run with an incompatible environment.', optionalCompatibilityExcluded: '$0 is an optional dependency and failed compatibility check. Excluding it from installation.',