Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(playwright): allow passing metadata from playwright test titles #635

Merged
merged 1 commit into from
May 8, 2023

Conversation

vovsemenv
Copy link
Contributor

No description provided.

@vovsemenv vovsemenv added the type:new feature New feature or request label Mar 9, 2023
@vovsemenv vovsemenv requested a review from baev March 9, 2023 09:53
Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove tags from test titles? Besides that, I'd like to have all the tags displayed as tags in the report

```ts
import { test, expect } from "@playwright/test";
test("test with allureId @allure.id=256", async ({}) => {});
test("tst with severity @allure.label.severity=critical", async ({}) => {});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@vovsemenv
Copy link
Contributor Author

fixes #634

Copy link
Member

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The feature looks very useful. Guess we can implement the same for rest reporters. Code looks nice. Good job! 👍

@baev baev merged commit 6c567df into master May 8, 2023
@baev baev deleted the playwright-metadata-from-title branch May 8, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants