Fix hermione repeat error #684
Conversation
| @@ -236,6 +248,7 @@ const hermioneAllureReporter = (hermione: Hermione, opts: AllureReportOptions) = | |||
| currentTest.addLabel(LabelName.LANGUAGE, "javascript"); | |||
| currentTest.addLabel(LabelName.FRAMEWORK, "hermione"); | |||
| currentTest.addLabel(LabelName.THREAD, thread); | |||
| currentTest.addParameter("browser", test.browserId); | |||
There was a problem hiding this comment.
do we want to show browserId in report itself? is it id or human-readable name? maybe better to make it hidden?
There was a problem hiding this comment.
I think, it would be very useful to know, which browser has been used in the test because we can use many of then in one run at once
There was a problem hiding this comment.
Yes, its really good if browserId is human-readable name. Thats my question
| @@ -220,6 +228,10 @@ const hermioneAllureReporter = (hermione: Hermione, opts: AllureReportOptions) = | |||
| }); | |||
| }); | |||
| hermione.on(hermione.events.TEST_BEGIN, (test) => { | |||
| if (!test.sessionId) { | |||
| throw new Error("Test session hasn't been started correctly! Check the driver availability."); | |||
There was a problem hiding this comment.
Do we fail whole test execution on this error of this thing affects only reporter side??
I remember we discussed that reporting cannot fail executions
There was a problem hiding this comment.
We do the same in the cucumber reporter. When session isn't initialized the reporter can't work correctly, so the error here looks reasonable from my side. What do you think, @baev?
Context
fixes #681
Additionally simplifies hermione package test process
Checklist