Zoom in / out not always working

[schroef]

I noticed the new zoom in/out functions in the file menu system. However they dont always react properly for me on OSX. Also cmd + doesnt zoom on my end, i need to press cmd shift + in order to get it working. However cmd - does work. Sometimes it doesn do anything and also the menu items dont respond? Cant figure out whats wrong there though.

[hummingly]

When I open the menu it also shows that I need to press ctrl + shift + = to zoom in.

[hummingly]

The solution is to change the shortcut in main.ts:

{ role: 'zoomin', accelerator: 'CmdOrCtrl+=' }

but then it shows it in the menu as ctrl + =. Furthermore, clicking the menu entry doesn't do anything. I will try to look whether I can add it manually.

[RvanderLaan]

Other people add two shortcuts for zooming in (for both + and =) but that looks a little weird.
An alternative would be to add the shortcuts in the HotKeys component, and then manually adjusting the webFrame.zoomFactor instead of letting electron handle the shortcuts

[hummingly]

@RvanderLaan I'm adding manually the click functionality for zoom in/out and reset menu entries right now because it does not work. Leaving the shortcut to the HotKey component seems fine but I haven't fixed my shortcut issue with it (shift+/ on non-american keyboards). Alternatively, we register it ourselvers or add a button to the settings menu to show the hotkeys.

[RvanderLaan]

Hmm, for me the buttons in the Electron toolbar work fine unless I'm focused on the devtools

[hummingly]

I tried the github release and packaged it myself but in both cases it does not zoom in/out or reset on clicking the menu entries in View. If I implement it myself, it does work.

[RvanderLaan]

Right, that's really weird, I didn't check the release version before. Nice that you found a workaround!

[schroef]

Im looking at the master and i get errors when packaging this master

[hummingly]

Did you try yarn install before packaging? I've updated electron and the packager.

[schroef]

ill try that, thanks!

[schroef]

Is there something which can check if dependencies are up to date? I seem to have this issue now and then. I dont see it until i try to package and then get an error

[hummingly]

Usually, you only see it in the commits or if your IDE keeps screaming at you that something is wrong even though it passed continous integration on Github already but else not that I know of.

[RvanderLaan]

Running yarn install (or just yarn) will do that, if everything is up to date it'll tell you that

[schroef]

Also awkward is that when i run yarn add electron i get version 5.0.0 but in the package.json it states dependencies "electron": "^6.0.1"?

[hummingly]

Basically, you're installing the latest version of electron. You probably have now two electron versions in your node_modules.

[schroef]

You have any ideas why i know see errors with the menu items in main.ts I had so many issues again. Not sure why or what, updated a bunch of files and now i get these errors. While earlier it was working just fine??

[hummingly]

Are you on master or another branch? This seems to be old code.

[schroef]

This is on master

[schroef]

Sorry this one is, but i get same error. The other one was i believe image-viewer-cssupdate.

[hummingly]

Hmm, can you try yarn install on master branch? The only issue you could have is that it cannot recognize the role appMenu in the if statement for apple in line 35 because that is in a higher electron 5 release.

[schroef]

okay, i try if electron will update to 6 i wouldnt do that earlier. It would update/install but it was 5.0.8 ??

[schroef]

Ps i just checked electron and it is actually 6.0.1 i believe i installed it again with npm this time?
Its quite confussing again

[schroef]

I now did yarn install and then electron is 5.0.8???

[hummingly]

What is written in you package.json? It should be 5.0.8. It could be that in your node_module folder contains two versions and those are conflicting but that shouldn't be the issue. Well, restarting vscode might help, otherwise delete node_modules folder and run yarn install.

[schroef]

i think yarn install did it know. Thought i did that already earlier today.

Thanks again