Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline - Wrong item top position with empty group #353

Open
Jamby93 opened this issue Jul 28, 2015 · 3 comments
Open

Timeline - Wrong item top position with empty group #353

Jamby93 opened this issue Jul 28, 2015 · 3 comments
Labels

Comments

@Jamby93
Copy link

Jamby93 commented Jul 28, 2015

When you scroll to the point that a group presents no items in the selected timerange, the other items shift up occupying a wrong group label.
See at https://almende.github.io/chap-links-library/js/timeline/examples/example13_grouping.html

Correct position:
image
Zoomed in, wrong position:
image

I've corrected it on line 5331 replacing options.groupMinHeight (which is 0 by default) to Math.max(options.groupMinHeight, group.labelHeight), although I don't know if it's the correct way to handle it.

@josdejong josdejong added the bug label Jul 28, 2015
@josdejong
Copy link
Contributor

Thanks for reporting this bug

@eye4brain
Copy link

In the case of myself , Math.max (options.groupMinHeight, group.labelHeight) + options.eventMargin and doing, it was just well adjusted . eventMargin the option has been set to 10 .

@IhorLaputin
Copy link

This bug can be fixed by set 'groupMinHeight'. Set static value of height like CSS height of the group bars.

Problem in the code related to the optimization:
when groups bars hidden from the visibility - legends on Axis bar still visible (groupItems). You count position of the bars that now in the visible but all legends still has visible options

PlassJ added a commit to PlassJ/chap-links-library that referenced this issue Jul 7, 2017
possible fix for (Timeline - Wrong item top position with empty group almende#353)
@PlassJ PlassJ mentioned this issue Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants