Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-controls instead of aria-owns? #565

Open
jeremyZX opened this issue Sep 26, 2022 · 2 comments
Open

aria-controls instead of aria-owns? #565

jeremyZX opened this issue Sep 26, 2022 · 2 comments

Comments

@jeremyZX
Copy link

In reviewing the WAI ARIA combobox pattern and seeing to what extent this library follows that pattern, I noticed that the form input is using aria-owns, which appears to be a ARIA 1.0 recommendation. At the bottom of the page, there is a note:

In ARIA 1.0, the combobox referenced its popup with aria-owns instead of aria-controls. While user agents might support comboboxes with aria-owns for backwards compatibility with legacy content, it is strongly recommended that authors use aria-controls.

Is there any possibility that you can update to use aria-controls instead of aria-owns, or a reason why one would not want to use aria-controls?

@eugeniosegala
Copy link

Echoing @jeremyZX, I have seen this being flagged as a critical accessibility issue by AXE:

Fix any of the following: Required ARIA attribute not present: aria-controls

Any chances we could update this? Happy to create a PR but wanted to discuss here before.

@36degrees
Copy link
Member

We've previously said this might be part of an intentional 'regression' to prefer the ARIA 1.0 pattern due to better support from assistive technologies.

That was 4 years ago, so you'd hope that support for the 1.1 pattern had improved regardless, but we need to understand the nuance of this change and ensure it's thoroughly tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants