Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests fail when an uncaught error or unhandled rejection happens in the browser #679

Open
1 task
romaricpascal opened this issue Mar 5, 2024 · 0 comments

Comments

@romaricpascal
Copy link
Member

What

Update our tests so they fail when an uncaught error or unhandled rejection happens in the browser.1

Why

Some tests may have their assertions pass, but an error being displayed in the console because of something breaking but not affecting the assertion. We should get aware of that so we can fix things.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Tests fail if an uncaught error or unhandled rejection happens in the browser.

Footnotes

  1. We may have to take the matter in our own hands there, as I couldn't find anything similar to the Puppeteer's pageerror event for Webdriver.io. Suspecting this is because Webdriver has to handle both Chrome (locally) and Sauce Labs. We might be able to spot errors by tracking the errors ourselves inside the browser through the error and unhandledrejection events, and checking in an afterEach block (or potentially through hooks)

katiehartrick added a commit to ecu-dmt/accessible-autocomplete that referenced this issue Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant