Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Enhanced Block Entities #44

Open
rayzchen opened this issue Dec 23, 2022 · 7 comments
Open

Incompatibility with Enhanced Block Entities #44

rayzchen opened this issue Dec 23, 2022 · 7 comments

Comments

@rayzchen
Copy link

Describe the bug
A clear and concise description of what the bug is.
Game crashes with Enhanced Block Entities and Dashloader in the mods folder.

To Reproduce
Steps to reproduce the behavior:

  1. Install fabric
  2. Install the two mods
  3. Launch minecraft
  4. Error log

Expected behavior
A clear and concise description of what you expected to happen.
No error

Screenshots
If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

  • DashLoader Version [e.g. 3.0-rc14] 4.1.3
  • Minecraft Version [e.g. 1.18.1] 1.19.3

Full Logs
Please always provide your entire minecraft logs when you report an issue to dashloader.
Upload them to sites like pastebin.com or paste.gg and then put the link here.
https://paste.gg/p/anonymous/550cebee77764ed4964f3ed1f24fb60d

Additional context
Add any other context about the problem here.
Didnt work with 1.19.2 but I don't remember the mod versions.

@PweSol
Copy link

PweSol commented Jan 7, 2023

I've been running EBE and DashLoader since forever and have never experienced a crash related to the combination of these two mods.

Minecraft Version [e.g. 1.18.1] 1.19.3

But you do mention your Minecraft version to be 1.19.3, and EBE is currently incompatible with that version. You need to wait for EBE to get updated. Also DashLoader v4.1.3 might not be compatible with 1.19.3 as well, where as the 5.0 version is.

@alphaqu
Copy link
Owner

alphaqu commented Jan 7, 2023

Hi there, DashLoader 4.1.3 does not support Minecraft 1.19.3, if you want DashLoader on 1.19.3 you can download the experimental 5.0 versions.

@rayzchen
Copy link
Author

rayzchen commented Jan 7, 2023

Funny, it launched fine with a few mods so I just assumed it was compatible. Why does 1.19.3, a minor version change, have to be so incompatible...

Taken from https://semver.org/:

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes
  2. MINOR version when you add functionality in a backwards compatible manner
  3. PATCH version when you make backwards compatible bug fixes

I guess Minecraft doesn't support SemVer then

@alphaqu
Copy link
Owner

alphaqu commented Jan 7, 2023

Its more that dashloader got a MAJOR change, not minecraft

@rayzchen
Copy link
Author

rayzchen commented Jan 7, 2023

Ah, didn't know that. Though I was referring more to lots of other mods crashing really badly even though they said 1.19.x

@MissPotato
Copy link

Off topic but want to clarify misinformation: the changes to 1.19.3 are minor from the perspective of a vanilla player. The changes in question included in 1.19.3 are a bunch of under the hood changes. These changes are very incompatible with mods because of it. I agree that Mojang should have waited till 1.20.0 to release the changes, but historically that hasn't been a consistent process by them.

From the perspective of a modded player, a lot of devs have decided the amount of work required to update to 1.19.3 outweighs the gains of 1.19.3. Especially considering a lot of the changes in 1.19.3 are future proofing and bedrock <-> java parity.

@rayzchen
Copy link
Author

I also found that out when I did some further reading. I'm not a mod developer, but wouldn't it be better to start working on a 1.19.3 update so that the jump to 1.20 isn't as huge? The features of 1.19.3 should be included in 1.20, unless Minecraft makes a complete rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants