Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Continuity 1.19.3 Emissives #56

Open
PepperCode1 opened this issue Feb 18, 2023 · 2 comments
Open

Incompatible with Continuity 1.19.3 Emissives #56

PepperCode1 opened this issue Feb 18, 2023 · 2 comments

Comments

@PepperCode1
Copy link

PepperCode1 commented Feb 18, 2023

Describe the bug
After the second resource reload (when resources are retrieved from the cache and the vanilla code paths are skipped), any emissive textures stop working.

To Reproduce
Steps to reproduce the behavior:

  1. Install Continuity 3.0.0-beta.2+1.19.3 and DashLoader 5.0.0-alpha.9+1.19.3.
  2. Start the game and load an emissive pack such as emissive ores.
  3. Restart the game and without changing the selected resource packs, enter a world.
  4. Observe that emissive textures are not applied.

Expected behavior
DashLoader should not prevent Continuity's emissives from working, as in versions before 1.19.3.

Context

  • DashLoader Version: 5.0.0-alpha.9+1.19.3
  • Continuity Version: 3.0.0-beta.2+1.19.3
  • Minecraft Version: 1.19.3

Additional Context
Since Continuity 1.19.3's code is not public yet, please contact me on Discord if you would like to inspect it for debugging purposes.

@alphaqu
Copy link
Owner

alphaqu commented Feb 18, 2023

Hey, can you please provide the entire logs before and after the cache has been made?

@noeysa2550
Copy link

Describe the bug After the second resource reload (when resources are retrieved from the cache and the vanilla code paths are skipped), any emissive textures stop working.

To Reproduce Steps to reproduce the behavior:

  1. Install Continuity 3.0.0-beta.2+1.19.3 and DashLoader 5.0.0-alpha.9+1.19.3.
  2. Start the game and load an emissive pack such as emissive ores.
  3. Restart the game and without changing the selected resource packs, enter a world.
  4. Observe that emissive textures are not applied.

Expected behavior DashLoader should not prevent Continuity's emissives from working, as in versions before 1.19.3.

Context

  • DashLoader Version: 5.0.0-alpha.9+1.19.3
  • Continuity Version: 3.0.0-beta.2+1.19.3
  • Minecraft Version: 1.19.3

Additional Context Since Continuity 1.19.3's code is not public yet, please contact me on Discord if you would like to inspect it for debugging purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants