Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should prevent the upload of Ugorit files in text area #633

Open
monzug opened this issue Jan 28, 2022 · 2 comments
Open

We should prevent the upload of Ugorit files in text area #633

monzug opened this issue Jan 28, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@monzug
Copy link

monzug commented Jan 28, 2022

One more related to issue #176.
Xml files can be uploaded from text area in Enter text. the upload is successful but the Ugorit content is displayed all in a continuous line. we should prevent the upload in Enter text for this specific files. Low priority.
see below
Screen Shot 2022-01-28 at 3 14 28 PM

@monzug monzug added the bug Something isn't working label Jan 28, 2022
@irina060981
Copy link
Member

Xml files can be uploaded from text area in Enter text. the upload is successful but the Ugorit content is displayed all in a continuous line. we should prevent the upload in Enter text for this specific files. Low priority.

I don't know how to do it.
Because we don't have any xml analysis inside application.
And Ugarit format does not have any references that is Ugarit.

If a user uploads an XML he should understand that he uploads TEI XML file, other wise it won't be handled with.
If we will try to understand if an uploaded file is TEI and reject those that are not like TEI - we could dig inside other problems.

So I suggest not to work with this issue.
@monzug , what do you think?

@irina060981 irina060981 assigned monzug and unassigned irina060981 Jan 29, 2022
@irina060981
Copy link
Member

And again it is not a bug - we don't have any strict requirements for uploaded xml - they should be TEI and it is from user's responsibility.
If we want more intelligent upload than - we should invest developing time in making application more clever - so it is enhancement

@irina060981 irina060981 added enhancement New feature or request and removed bug Something isn't working labels Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants