Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xresources light (commented out) broken #382

Open
egmontkob opened this issue Sep 6, 2018 · 1 comment
Open

xresources light (commented out) broken #382

egmontkob opened this issue Sep 6, 2018 · 1 comment

Comments

@egmontkob
Copy link

xresources/solarized defines the dark color scheme correctly, and contains an incorrect definition for the light one in comments.

It reverses the order of base03..base3. According to the section "The Values" on Solarized homepage all the 16 indices have a fixed RGB, there's no shuffling. According to "Usage & Development" there, it's the responsibility of applications to reverse the order (e.g. wherever they'd pick base01 on dark background, pick base1 on light background).

The upstream location https://github.com/solarized/xresources seems to have this fixed.

@egmontkob
Copy link
Author

(Nitpicking: let's also mention the silly order of color9 followed by color8.)

cdleonard added a commit to cdleonard/public-dotfiles that referenced this issue Feb 7, 2022
See: altercation/solarized#382

Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant