Skip to content
This repository has been archived by the owner on Apr 13, 2024. It is now read-only.

rendering internal elements based on parent logic #43

Open
ghost opened this issue Jun 26, 2019 · 0 comments
Open

rendering internal elements based on parent logic #43

ghost opened this issue Jun 26, 2019 · 0 comments
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jun 26, 2019

Hello there and thanks for this awesome project.
One thing that bothers me is that for components that considered as containegg in the code, putting aside "div", all the others have some logic defined for rendering their children.
for instance consider list, or card in most of component libraries. or list item it self provides us with some rendering logic and predefined style and design for their children tags.
but here in vuegg there is no possibility for parent components to properly render their child components because what they see is StageEl wrapper around the element and preventing the element to be the direct child of it's parent. this is not an issue considering div's, but when it comes to using 100% container components in every component libraries, this is the case.

My suggestion :)

In StageEl module you are gathering all the children of an element and creating these children wrapped in StageEl. the case here is that we check if the component has containegg property of true, then we do the same iteration on children and creating each child, but this time instead of creating the element as an StageEl, we go for child.type itself. this will solve the rendering problem but will prevent us from position handling of the Child elements; but still is a better practice because we still have the chance to do each container one at a time and then integrate them with upper hand parent. for instance i will first start designing my list item itself. when it is ready i will drag it inside my list, i can not modify the list item further, but i had the chance before integration. :)

the other thing is that most of the components libraries are handling their components internal content positioning using flex box. we can still use absolute positioning for the direct children of Stage, but for internal children of components we can go for a flex based solution. i do not know how that can be possible ever, but if you have any suggestion about it i would be glad to contribute.

for the moment i managed to integrate quasar into your awesome system, but it is sad when we can not benefit the features these libraries are providing us and we are stopped at the first step.

THANKS in advance. 👍

@alxpez alxpez added feature New feature or request help wanted Extra attention is needed labels Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant