Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #54

Open
aletfa opened this issue Jun 9, 2021 · 10 comments
Open

Typescript support #54

aletfa opened this issue Jun 9, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@aletfa
Copy link

aletfa commented Jun 9, 2021

Please implement the @types/luxon-business-days in order to work with typescript, like the main library 馃憣

@amaidah
Copy link
Owner

amaidah commented Jul 26, 2021

moment/luxon#228 Looks like there is a 3rd party that provides the types for Luxon.

Are you requesting that I submit types into DefinitelyTyped?

@jkraft-s1a
Copy link

I'd like to see types submitted to DefinitelyTyped. That would be a helpful addition for anyone using TypeScript, and some IDEs point you in that direction. For example, from Visual Studio Code:
image

@alexkates
Copy link

+1

@wowczarczyk
Copy link

It is currently more common to include the types in the repo instead of using DefinatelyTyped

@sdc-wag
Copy link

sdc-wag commented Nov 11, 2021

+1

@amaidah amaidah added the enhancement New feature or request label Feb 23, 2022
@xinthose
Copy link

I will stick with moment-business-days until this is completed.

@cwancy
Copy link

cwancy commented Dec 4, 2022

+1

@fdemello
Copy link

image image

@bcbailey
Copy link

I've submitted a PR to add typings
DefinitelyTyped/DefinitelyTyped#69446

@bcbailey-torus
Copy link

@types/luxon-business-days has been published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests