fix: Make link in error clickable in GH Actions #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amannn
reviewed
Jul 26, 2021
Co-authored-by: Jan Amann <jan@amann.me>
|
Great, thanks. I agree it makes sense to be on the safe side by removing the trailing period. |
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PRs that fail due to the error "No release type found in pull request title", the resulting GH Actions log message link to https://www.conventionalcommits.org/ erroneously includes the closing parenthesis that results in a Page Not Found error when the link is clicked. For example, see this job in the public rust-bio repo.
This PR adjusts the error message text to remove the parentheses and thereby make the link point to the correct location. See here for the job output of a mock PR in a mock repo that uses my forked workflow with the change.