feat: Allow for custom types #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amannn
commented
Oct 19, 2020
| @@ -1,6 +1,6 @@ | |||
| name: 'Lint PR title' | |||
| on: | |||
| pull_request_target: | |||
| pull_request: | |||
There was a problem hiding this comment.
I've changed this to run checks against this branch. It seems like this only works properly when it's the owner making the PR.
amannn
commented
Oct 19, 2020
| # Optionally you can configure which types are allowed. | ||
| # Default: https://github.com/commitizen/conventional-commit-types | ||
| with: | ||
| types: fix, feat |
There was a problem hiding this comment.
This is a string, as Github Actions doesn't support array arguments currently.
amannn
commented
Oct 19, 2020
| @@ -7,3 +7,6 @@ runs: | |||
| branding: | |||
| icon: 'shield' | |||
| color: 'green' | |||
| inputs: | |||
| types: | |||
There was a problem hiding this comment.
Conventional commits calls these "types", therefore I'd go for the same terminology.
This was referenced Oct 19, 2020
Closed
amannn
commented
Oct 19, 2020
| const {parserOpts} = await conventionalCommitsConfig(); | ||
| const result = parser(prTitle, parserOpts); | ||
|
|
||
| function printAvailableTypes() { |
There was a problem hiding this comment.
Sneaked in another improvement here: #45
|
Hey @amannn Will you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #47 and #52.
It seems there are some issues with running the latest changes from a branch within a PR workflow, therefore I opened another PR which contains the relevant changes from #47 and #52.
The new behaviour can for example be seen here: https://github.com/amannn/action-semantic-pull-request/runs/1273430601
Resolves #39
Resolves #45
Closes #47
Closes #52