Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react@"18.0.0" support #112

Open
ant1m4tt3r opened this issue May 17, 2022 · 3 comments
Open

react@"18.0.0" support #112

ant1m4tt3r opened this issue May 17, 2022 · 3 comments

Comments

@ant1m4tt3r
Copy link

Hey! Can we add react@"18.0.0" as a supported version for this package? It seems to be working fine for me in this version, but I have to install it using npm i react-credit-cards --force. Without the --force flag it fails because of the peer dependency not allowing react-18.

If you guys approve the idea, I can make a quick PR and check if tests are still passing.

@felquis
Copy link

felquis commented Jun 27, 2022

Try react-credit-cards-2 mentioned at #115

@SeanCassiere
Copy link

SeanCassiere commented Sep 29, 2022

There are two PRs open right now that specifically upgrade the React dependency to 18 and are awaiting approval.
#116
#117

@gilbarbara @cassiocardoso as the two biggest contributors in the past, would y'all have any sway on getting these React peer deps approved?

Try react-credit-cards-2 mentioned at #115

Using this fork really doesn't make sense when it could be easily done so in the main package... Not to mention the community types for the official package.

@waleedshkt
Copy link

Looks like the maintainers of this package are inactive for quite some time now. Anyone, possibly, getting in touch with them to notify them will be of great help.

Of course, a separate spin-up repo with new maintainers will be great. But considering the popularity and contribution on this original project, it seems more important to get the original authors back online. They then can select new maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants