Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping node@6. #151

Closed
wtgtybhertgeghgtwtg opened this issue Aug 17, 2019 · 2 comments
Closed

Consider dropping node@6. #151

wtgtybhertgeghgtwtg opened this issue Aug 17, 2019 · 2 comments

Comments

@wtgtybhertgeghgtwtg
Copy link
Collaborator

Mostly so micromatch can be bumped. micromatch@3 has some notable performance and size penalties but micromatch@4 requires node>=8. This'd probably close #143 and make #147 a little more straightforward. jest is also currently looking to drop node@6 support for the next major, so it'd need this to be done to fully feel the effects.

I'll file a PR if this is acceptable.
@SimenB SimenB mentioned this issue Sep 4, 2019
Open
@stefanpenner
Copy link
Collaborator

I'm going to drop 6,8, supporting 10 + >= 12 as node 8 EOLs shortly.

@COScholl
Copy link
Collaborator

Changes made by @stefanpenner have been merged do drop support for older versions of node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @wtgtybhertgeghgtwtg @COScholl