Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close race condition with watch and readdir #27

Open
krisselden opened this issue Sep 22, 2014 · 1 comment
Open

close race condition with watch and readdir #27

krisselden opened this issue Sep 22, 2014 · 1 comment

Comments

@krisselden
Copy link

Calling close on a watcher closes currently watched directories but does not account for asynchronous callbacks.

Easiest way to reproduce is to create a watcher and try to close it right away.

@krisselden
Copy link
Author

To clarify, if you close during an async op who's callback calls Watcher.prototype.watchdir then Watcher.prototype.watchdir should guard against the state of being closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant