Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding node_modules in watcher #72

Open
guybedford opened this issue Aug 21, 2016 · 3 comments
Open

Excluding node_modules in watcher #72

guybedford opened this issue Aug 21, 2016 · 3 comments

Comments

@guybedford
Copy link

If running the Node native watcher on a folder that contains a large node_modules directory, we want the ability to ignore this folder.

Is there any way in this project (or with the Node native watcher for that matter), to handle use cases like this?

See jspm/jspm-cli#1999 for more info.

@amasad
Copy link
Owner

amasad commented Aug 21, 2016

Have you tried the globs option?

On Sun, Aug 21, 2016, 2:20 AM Guy Bedford notifications@github.com wrote:

If running the Node native watcher on a folder that contains a large
node_modules directory, we want the ability to ignore this folder.

Is there any way in this project (or with the Node native watcher for that
matter), to handle use cases like this?

See jspm/jspm-cli#1999 jspm/jspm-cli#1999 for
more info.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#72, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj2_hYFYCQ0ulG8gN8Y6-e5QvcROcmkks5qiBhAgaJpZM4JpQni
.

@guybedford
Copy link
Author

See the discussion previously at jspm/jspm-cli#1775 (comment).

The issue is that because we know the specific module tree, we do know exactly which individual files to watch.

I'm wondering if it's worth just falling back to a custom fs.watch call here on the specific directories we know we need to listen to, as we don't need recursion actually.

@amasad
Copy link
Owner

amasad commented Aug 22, 2016

Yeah that might make sense. We can also have a predicate function that gets called on directories and if returns false it will skip watching that dir or any of it's descendants. I don't have the time to do any work on this. So let me know what works for you and patches welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants