Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array params have indexes now #47

Open
samdemaeyer opened this issue Oct 18, 2018 · 2 comments
Open

Array params have indexes now #47

samdemaeyer opened this issue Oct 18, 2018 · 2 comments

Comments

@samdemaeyer
Copy link

Since the introduction of nested params, there seems to be something weird going on.
The nested array params have now number inside. include[0]: 'Foo', include[1]: bar

I know it's this way because we cannot have duplicate keys in a javascript object, but would it be possible to go back to work with an array. Or is this intended behavior @amiel 😅 ?

Before:
screenshot 2018-10-18 at 15 11 02

After:
screenshot 2018-10-18 at 15 05 42

@amiel
Copy link
Owner

amiel commented Oct 18, 2018

@samdemaeyer I'll admit that this was not intentional. I'm not sure how best to address it though.

I would gladly merge a fix if you have any ideas, so feel free to give it a shot. Otherwise I'm happy to look in to it, but I can't guarantee it will be any time soon.

@amiel
Copy link
Owner

amiel commented Oct 30, 2018

I'm going to reopen this, as it is definitely still a bug, we just don't have a solution for it yet.

@amiel amiel reopened this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants