Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is Node v8.x required? #224

Closed
niftylettuce opened this issue Apr 25, 2019 · 9 comments · May be fixed by ajesse11x/core#1
Closed

Why is Node v8.x required? #224

niftylettuce opened this issue Apr 25, 2019 · 9 comments · May be fixed by ajesse11x/core#1

Comments

@niftylettuce
Copy link

https://github.com/amilajack/eslint-plugin-compat/blob/master/package.json#L70

niftylettuce added a commit to ladjs/superagent that referenced this issue Apr 25, 2019
@ljharb
Copy link
Collaborator

ljharb commented Apr 25, 2019

it was done in #218, presumably to be able to transpile to a later target.

@amilajack
Copy link
Owner

amilajack commented Apr 25, 2019

It's not really required. As a maintainer I didn't want to handle bug reports for older versions. But if you need support for older versions I'll lower the node version requirement. Should be as simple as a babel-preset-env target change and engines version change

@niftylettuce
Copy link
Author

If we could remove the requirement in engine of package.json that would be great

@ljharb
Copy link
Collaborator

ljharb commented Apr 25, 2019

eslint itself requires node 4, and babel 7 requires node 4 as well i think - so removing it isn't an option, but dropping it down to 4 should be.

@niftylettuce
Copy link
Author

niftylettuce commented Apr 25, 2019 via email

@amilajack
Copy link
Owner

Yarn supports >=8 so we're locked to that same semver because of users who install this lib with yarn

@ljharb
Copy link
Collaborator

ljharb commented Dec 30, 2019

Um, that’s not how it works - npm users aren’t locked to that, and older versions of yarn won’t require node 8.

An eslint plugin should always support every node version eslint supports.

@amilajack amilajack reopened this Dec 30, 2019
amilajack added a commit that referenced this issue Dec 30, 2019
@amilajack
Copy link
Owner

@ljharb
Copy link
Collaborator

ljharb commented Dec 30, 2019

The latest version does, but there’s no reason we need to use > v6 - v7 only changes prerelease logic.

Let’s stop looking for excuses to drop support, and try to support as far back as possible?

@amilajack amilajack reopened this Dec 30, 2019
amilajack added a commit that referenced this issue Dec 31, 2019
* fix: #224

* downgrade semer to @6.3.0

* Update package.json

Co-Authored-By: Jordan Harband <ljharb@gmail.com>

Co-authored-by: Jordan Harband <ljharb@gmail.com>
Morita0711 added a commit to Morita0711/npm-superurgent that referenced this issue Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants