-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positives reported violation when mdn-browser-compat-data uses ranged version #446
Comments
Oh, it looks like the issue rather is that Ideally, both projects (ast-metadata-inferer and eslint-plugin-compat) should upgrade to Fwiw, adding it("should support ranged versions", () => {
const node = { protoChainId: "Accelerometer" };
const config = determineTargetsFromConfig(".", "edge 18, edge 87");
const targets = parseBrowsersListVersion(config);
const result = getUnsupportedTargets(node, targets);
expect(result).toEqual(["Edge 18"]);
}); to On the other hand, as reported initially: it("should support ranged versions", () => {
const node = { protoChainId: "location.hostname" };
const config = determineTargetsFromConfig(".", "opera 71");
const targets = parseBrowsersListVersion(config);
const result = getUnsupportedTargets(node, targets);
expect(result).toEqual([]);
}); fails:
|
Having a similar issue with |
I recently updated all my dependencies after a few months, and now have a report:
Looking around in related projects, I found that mdn-browser-compat-data have recently updated their data for
location.hostname
fromtrue
to a ranged version, specifically"version_added": "≤12.1"
, and it looks like eslint-plugin-compat doesn't support that format (parsing strings as a semver, which itself doesn't deal with the≤
character).The text was updated successfully, but these errors were encountered: