Are Array Prototype Methods Supported?

[matthewwithanm]

Hey! I'm very confused about the status of Array prototype methods. There are a bunch of open issues about them with conflicting information about how/whether these are meant to be supported. The README specifically calls out using Array.prototype.push(), but I can't seem to get errors for .flatMap(), or .flat().

I was going to comment on the recently opened #539 about .at(), but after some troubleshooting it seems like maybe that's a separate issue? For x.flat(), the check is reaching this code but not matching because objectName is "x":

const failingRule = rules.find(
  (rule) =>
    rule.object === objectName &&
    (rule.property == null || rule.property === propertyName)
);

For [].flat(), it hits this branch but doesn't match because protoChainId is ".flat", instead of the rule's "Array.flat":

const protoChain =
  firstObj === "window" || firstObj === "globalThis"
    ? rawProtoChain.slice(1)
    : rawProtoChain;
const protoChainId = protoChain.join(".");
const failingRule = rules.find(
  (rule) => rule.protoChainId === protoChainId
);

.at() (#539) seems to have a different problem in that there's no rule for it in the list.

What's the expected behavior for these two cases? Should they cause failures? Is this a bug, or is the README just out of date?

Thanks for the help!

[koddsson]

Is this still not working in the latest version (4.1.4)? I think I've fixed it there. If not still working, can you provide a small reproduction case that we can take a look at?