Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment error #30

Open
jackguoAtJogg opened this issue Aug 21, 2020 · 6 comments · May be fixed by #31
Open

Deployment error #30

jackguoAtJogg opened this issue Aug 21, 2020 · 6 comments · May be fixed by #31
Assignees
@amondnet
Labels
Priority: High Type: Bug Bug or Bug fixes

Comments

@jackguoAtJogg
Copy link

jackguoAtJogg commented Aug 21, 2020 •
edited

I'm getting this error when deploying using vercel-action. Don't know if anyone else ran into the same error.

I was able to deploy in my local terminal using now cli.

image
@AlexRekish
Copy link

we have the same error

@pi-dal
Copy link

pi-dal commented Aug 22, 2020

I have the same error!😢

@amondnet amondnet self-assigned this Aug 22, 2020
@amondnet
Copy link
Owner

amondnet commented Aug 22, 2020 •
edited

@jackguoAtJogg It works fine in my tests. Please show me your action.yaml file or action log file.

https://github.com/amondnet/vercel-action/runs/1015410039?check_suite_focus=true
https://github.com/amondnet/vercel-action/runs/1015410052?check_suite_focus=true

@amondnet amondnet linked a pull request Aug 22, 2020 that will close this issue
Open
@amondnet
Copy link
Owner

amondnet commented Aug 22, 2020 •
edited

I just reproduced the error.
https://github.com/amondnet/vercel-action/pull/31/checks?check_run_id=1015424822

vercel inspect express-basic-auth-m7ecjdzvj.vercel.app

> Fetched deployment "express-basic-auth-m7ecjdzvj.vercel.app" in amond [2s]

  General

    version     2
    id          dpl_DbQTwq1Cz9ydVk4VdRSPvLqTud9V
    name        express-basic-auth
    readyState  READY
    url         express-basic-auth-m7ecjdzvj.vercel.app


Error! An unexpected error occurred in inspect: Error: val is not a non-empty string or a valid number. val=null
    at Object.e.exports [as default] (/Users/amond/.nvm/versions/node/v10.16.0/lib/node_modules/vercel/dist/index.js:2:1084484)
    at elapsed (/Users/amond/.nvm/versions/node/v10.16.0/lib/node_modules/vercel/dist/index.js:2:22853)
    at main (/Users/amond/.nvm/versions/node/v10.16.0/lib/node_modules/vercel/dist/index.js:2:1305541)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Deployment works fine, but there is a problem with inspect.
Related Issues: #27 #28 #29 .
Currently, the most stable way is to set vercel-project-name inside the GitHub Actions yaml config.

        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          vercel-token: ${{ secrets.VERCEL_TOKEN }}
          vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
          vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID_AUTH }}
          working-directory: example/express-basic-auth
          vercel-project-name: express-basic-auth #your project name

@jackguoAtJogg
Copy link
Author

@amondnet Yep by setting vercel-project-name the deployment is successful. I don't see vercel-project-name is a required field from README, so will that be fixed in the future?

@facosta0787
Copy link

Same Error, I added the vercel-project-name and it stills failing

image

My action file

`name: Deploy to VERCEL
on:
push:
branches:
- master
jobs:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

  - name: Install Node.js
    uses: actions/setup-node@v1
    with:
      node-version: '10.x'

  - name: Install yarn
    run: npm i -g yarn

  - name: Install packages and run tests
    run: yarn && yarn test

  - name: Run Eslint
    run: yarn lint

  - name: Deploy to Vercel
    uses: amondnet/vercel-action@v19.0.1+3
    with:
      vercel-token: ${{ secrets.VERCEL_TOKEN_ID }} # Required
      github-token: ${{ secrets.GH_TOKEN }} #Optional
      vercel-args: '--prod' #Optional
      vercel-org-id: ${{ secrets.VERCEL_ORG_ID}} #Required
      vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID}} #Required
      working-directory: ./
      vercel-project-name: simetrik

`

johnkors added a commit to blankoslo/about-blank that referenced this issue Sep 24, 2021
@johnkors
Set vercel project name due to bug in action
8ad4e71 
amondnet/vercel-action#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amondnet amondnet

Labels
Priority: High Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: gh-30 deployment error amondnet/vercel-action
5 participants
@amondnet @facosta0787 @AlexRekish @pi-dal @jackguoAtJogg