Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TCP keepalive option in BindContext #67

Open
kelunik opened this issue Oct 23, 2019 · 2 comments
Open

Support TCP keepalive option in BindContext #67

kelunik opened this issue Oct 23, 2019 · 2 comments

Comments

@kelunik
Copy link
Member

kelunik commented Oct 23, 2019

No description provided.

@bzikarsky
Copy link

What about the ConnectContext? We have a client use-case that would profit from TCP keepalive (long-running HTTP 2.0 connections through a proxy that drops IDLE connections without keepalive)

I'd be open to provide a simple MR adding this to ConnectContext and BindContext. Implementation-wise we'd have a bit of an outlier because you cannot set tcp-keepalive in the stream-context array. Instead, we'd need to call socket_import_stream and socket_set_option on after stream_socket_server/stream_socket_client.

WDYT?

@kelunik
Copy link
Member Author

kelunik commented May 10, 2021

We'll need to decide what to do if the socket extension isn't available then, ignore or error?

Otherwise same for Connect Context, yes.

For HTTP/2 you could also use pings at the application layer instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants