Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create domain command not updating security policy to use minimum TLS version specified #516

Open
shubsaini09 opened this issue Sep 16, 2022 · 0 comments
Labels

Comments

@shubsaini09
Copy link

Question
Create domain command not updating security policy to use minimum TLS version specified

Command Run
serverless create_domain

Issue Description
As per the AWS docs we can specify the security policy parameter to use the minimum TLS version given in it. If I update my domain using AWS CLI and check in here then TLS 1.0 and TLS1.1 show as disabled. But when I perform the same thing using the serverless create domain command, it has no effect on enforcing the minimum TLS version. It does update the TLS to 1.2 but TLS 1.0 and 1.1 is still enabled.

Domain Manager Configuration

custom:
  customDomain:
    domainName: ${self:custom.config.environment.domain}
    basePath: 'v1'
    stage: ${self:custom.config.environment.envRuntime}
    createRoute53Record: ${self:custom.config.environment.createRoute53Record}
    certificateName: ${self:custom.config.environment.certificate}
    endpointType: 'regional'
    securityPolicy: tls_1_2

Versions

  • Domain Manager version(s): 6.1.0

Command Logs

Serverless: Invoke create_domain
Serverless Domain Manager: [Info] Custom domain 'xyz.com' already exists.
Serverless Domain Manager: [Info] Creating/updating route53 record for 'xyz.com'.
Serverless Domain Manager: [Info] Skipping creation of Route53 record.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant