Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple domain support #88

Closed
JamesKyburz opened this issue Jan 22, 2018 · 12 comments · Fixed by #327 or #386
Closed

Multiple domain support #88

JamesKyburz opened this issue Jan 22, 2018 · 12 comments · Fixed by #327 or #386

Comments

@JamesKyburz
Copy link

Would you be interested in a pull request that adds support for multiple domains (per stage).

That is I would like www.example.com and example.com to point to the same aws lambda.

Unless this is already possible?

@captainsidd
Copy link
Contributor

Hi there! Is this possibly what you are looking for?

@JamesKyburz
Copy link
Author

@sidgonuts Thanks, I need that too :) But I also need multiple domains per stage too.

I will be registering multiple domains pointing to the same lambda for each stage. All this to achieve redirects from say example.com to www.example.com.

@thejuan
Copy link

thejuan commented Mar 21, 2018

I'd like this too. I use AWS linked account per environment and use domain delegation.

Root Account:
api.example.com CNAME api.master.example.com

Master Account:
api.master.example.com CNAME {apigateway regional domain}

Each of my service stages need two custom domains

@Vadorequest
Copy link

I need this as well, because I deploy under one kinda private domain, under the company name, and I also deploy in my customer's domain which simply proxy the requests to my main API Gateway.

I wonder if I can use both this plugin AND a an API Gateway custom domain resource?
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-domainname.html

If that's possible to use both (have severless-domain-manager to configure the main domain (company) and have the proxy domain deployed through the SLS resources? If so it also fix my issue.

@captainsidd
Copy link
Contributor

@JamesKyburz it seems like there's enough people that would like this functionality. If you would like to make a pull request for that, that'd be great. Thanks!

@et304383
Copy link

@JamesKyburz are you still looking to add a PR to support this? We need this too.

@kidculli
Copy link

We need this as well

@yilinjuang
Copy link

Any updates? Would be great to have this

@ricardovf
Copy link

This would be great for our use case too!

@ConradKurth
Copy link
Contributor

@ricardovf @frankyjuang @kidculli I made a PR with this change if you wish to use it!

@s-kris
Copy link

s-kris commented Sep 4, 2020

This would be great use case, waiting.

@casualuser
Copy link

It look like #327 is pending for 5 months already. Is there something real preventing merge and deliver a such a high demand feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet