Added stack search in Nested Stacks

[Katafalkas]

Fixes #209

Description of Issue Fixed
getRestApiId() would not find restApiId if CloudFormation Nested Stacks are used.

Changes proposed in this pull request:

• Search for stack match in all stacks

Code used as reference: #209 (comment)

[Katafalkas]

Maybe there should be an option useNestedStacks ?

[codetheweb]

Hey @captainsidd any update on this?

We're currently running into the issue this PR fixes.

[wizardishungry]

Yea, I'm eagerly waiting on this to merge!

[logiclord]

would love to see this request through

[vodlogic]

We would also love this PR to be merged as soon as possible

[Katafalkas]

while this PR is not merged - you can try using my branch. Leave comments what could be improved.

"serverless-domain-manager": "Katafalkas/serverless-domain-manager#with-js-artifact"

[vodlogic]

while this PR is not merged - you can try using my branch. Leave comments what could be improved.

"serverless-domain-manager": "Katafalkas/serverless-domain-manager#with-js-artifact"

This PR works fine for our use case. I did see errors with serverless-certificate-creator not being able to find the nested stacks but this did not seem to affect anything and obviously a different bug entirely. Great that you have added support for large number of nested stacks aswell. I have not specifically tested this works - we had 20 stacks in our account at the time.

Would be great if this PR can be approved and merged soon.

[Katafalkas]

while this PR is not merged - you can try using my branch. Leave comments what could be improved.
"serverless-domain-manager": "Katafalkas/serverless-domain-manager#with-js-artifact"

This PR works fine for our use case. I did see errors with serverless-certificate-creator not being able to find the nested stacks but this did not seem to affect anything and obviously a different bug entirely. Great that you have added support for large number of nested stacks aswell. I have not specifically tested this works - we had 20 stacks in our account at the time.

Would be great if this PR can be approved and merged soon.

Will update the code to remove the error.

[webhacking]

@Katafalkas It works great. thx bro

[Katafalkas]

If you use serverless 1.55.0 version and try installing this plugin via npm my github branch, serverless will not import it. Can not figure our why. Waiting for response to my ticket.

serverless/serverless#6884

A workaround - move plugin to .serverless_plugins - hacky, but works for now.

[vodlogic]

If you use your with-js-artifact branch it seems to work on serverless 1.56.1

[russell-dot-js]

If you use serverless 1.55.0 version and try installing this plugin via npm my github branch, serverless will not import it. Can not figure our why. Waiting for response to my ticket.

serverless/serverless#6884

A workaround - move plugin to .serverless_plugins - hacky, but works for now.

I got it working by adding a postinstall script:
"postinstall": "cd node_modules/serverless-domain-manager && npm ci && npm run build"

[russell-dot-js]

Can we get this merged though? This is a great fix for a common issue - API gateway takes a ton of resources, so splitting the stacks is pretty common

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

No Coverage information
0.0% Duplication

[Katafalkas]

Updated code. Did a rebase on #313

"serverless-domain-manager": "Katafalkas/serverless-domain-manager#working-artifacts-2020-02-17"

[russell-dot-js]

FWIW, this PR has been open for almost a year, with multiple consumers testing in production and no complaints... what's a dev gotta do to get his PR merged around here? I can't imagine this is very rewarding for @Katafalkas to put his time into maintaining this library only for crickets from the repository admins.

I am in OC with amplify-education, should I deliver donuts?

[aoskotsky-amplify]

Hey. Sorry for the long delay in reviewing this PR/getting it merged. We'll review this one next once the merge conflicts are resolved and try to get it merged ASAP.

[nilsdebruin]

It would be nice if this pull request could be merged; avoiding nested stacks is better, but sometimes you have to go with them...