Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for regional domains using TLS 1.0 #348

Merged
merged 7 commits into from May 25, 2020

Conversation

aoskotsky-amplify
Copy link
Member

Fixes #341

Description of Issue Fixed
Previous versions of this plugin used the V2 API Gateway API for all regional domains but the V2 plugin only supports TLS 1.2 domains so we need to fall back to the V1 API for TLS 1.0 domains.

Changes proposed in this pull request:

  • Check for TLS 1.0 when deciding to use V1 or V2 API Gateway API
  • Add unit and integration tests

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aoskotsky-amplify aoskotsky-amplify merged commit 88a558e into master May 25, 2020
@aoskotsky-amplify aoskotsky-amplify deleted the fix_regional_tls_1_0 branch May 25, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreported breaking change due to change in APIGateway API
2 participants