Invalid TS return type for getDeviceId()

[bertrand-caron]

Hi,

While browsing the docs, I encounter the following sentence:

You can retrieve the Device ID that Amplitude uses with Amplitude.getInstance().getDeviceId(). This method can return null if a Device ID has not been generated yet.

However, the types list it as returning a string:

Amplitude-ReactNative/src/types.ts

Line 27 in 183a6b0

getDeviceId(instanceName: string): Promise<string>;

Shouldn't this be changed to getDeviceId(instanceName: string): Promise<string | null>;?

[yuhao900914]

Hi @bertrand-caron , thanks for your feedback.
Yes, deviceId is possible to be null if it's not initialized yet on the native side. It should be changed like what you mentioned.

[jeff-polls]

@yuhao900914 this issue is causing crashes in my app. What is the recommended method if we need to get the Device ID once it is initialized? Currently we are doing await init() then await getDeviceId() but on first launch we're getting null

[bertrand-caron]

@jeff-polls @yuhao900914 I also experiences issues with getDeviceId() returning null; would love to add that to the roadmap if possible?