Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors found in AndroidManifest.xml #168

Open
gilluminate opened this issue Jul 11, 2023 · 7 comments
Open

Errors found in AndroidManifest.xml #168

gilluminate opened this issue Jul 11, 2023 · 7 comments

Comments

@gilluminate
Copy link

After upgrading to latest version, when I run npx pod-install I get the following error:

Auto-generating `.xcode.env.local` with $NODE_BINARY=/Users/runner/hostedtoolcache/node/18.16.1/x64/bin/node
error Failed to build the app: No package name found.
Found errors in [...]/node_modules/@amplitude/react-native/android/src/main/AndroidManifest.xml.
@deivyrene
Copy link

The same thing happens to me without updating dependencies

error Failed to build the app: No package name found. Found errors in node_modules/@amplitude/react-native/android/src/main/AndroidManifest.xml.

@ejain
Copy link

ejain commented Jul 12, 2023

This affects anyone using React Native 0.70 or earlier, see #167.

@yuhao900914
Copy link
Contributor

Thank you for choosing Amplitude. We are actively investigating this issue.

@yuhao900914
Copy link
Contributor

This is a bug related to RN and RN CLI. I found the same issue in the react-native-community/cli repo here.

And they have a fix here. Please follow their instruction to update the version.

The current React Native ^0.71.0 using react-native-community/cli ^10.0.0. So it should include the fix.
Check here.

@ejain
Copy link

ejain commented Jul 12, 2023

We're using React Native 0.70.x, doesn't look like the fix was backported to that version...

What versions of React Native does Amplitude-ReactNative support, officially?

@yuhao900914
Copy link
Contributor

@ejain Let me get back to you after a discussion with our team.

@yuhao900914
Copy link
Contributor

Hi @ejain, since React-Native is still in beta, it's challenging for us to ensure backward compatibility when React-Native itself is not backward compatible. Therefore, we've decided to support only the latest version of React-Native until it is out of beta. Once React-Native reaches GA, we will improve our support and strive for backward compatibility.

In the meantime, please use the older version of our React-Native SDK to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants