You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding istanbul instrumentation via browserify to gulp build slows down the build by an order of magnitude and doesn't change the coverage measured (#22567 (comment)). Not sure what else can be done, or if it's even feasible to measure code coverage for built JS files that are loaded by webpages during tests.
[Infra triage] Some progress has been made towards accurately measuring coverage during integration / e2e tests since this issue was filed. See #30463, #30129, #31787 (abandoned). Putting this on the radar of @rileyajones in case there is other low-hanging fruit that will allow us to get coverage numbers during CI.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
Today, the code coverage measured by the integration tests is ~31%.
This is inaccurate because we're not instrumenting the built runtime used in
commonIntegrationTestPaths
.amphtml/build-system/config.js
Lines 36 to 62 in aafa151
Adding
istanbul
instrumentation viabrowserify
togulp build
slows down the build by an order of magnitude and doesn't change the coverage measured (#22567 (comment)). Not sure what else can be done, or if it's even feasible to measure code coverage for built JS files that are loaded by webpages during tests./cc @ampproject/wg-infra @aghassemi
The text was updated successfully, but these errors were encountered: