Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to include closure libraries in compilation ? #73

Open
Feiyang1 opened this issue Sep 25, 2018 · 1 comment
Open

How to include closure libraries in compilation ? #73

Feiyang1 opened this issue Sep 25, 2018 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@Feiyang1
Copy link

Feiyang1 commented Sep 25, 2018

I'm using closure library with goog.require syntax, e.g.

goog.require('goog.net.createWebChannelTransport');

On compilation, I got error that says required "goog.net.createWebChannelTransport" namespace never provided. I have tried to set js properties in compiler options like:

compiler({
    js: 'node_modules/google-closure-library/closure/goog/**/*.js'  
})

but it doesn't work. Am I doing something wrong? How do I include closure libraries in compilation?

@kristoferbaxter kristoferbaxter added the question Further information is requested label Sep 25, 2018
@kristoferbaxter kristoferbaxter self-assigned this Sep 25, 2018
@aldo-roman
Copy link

aldo-roman commented Dec 11, 2018

Hi @kristoferbaxter any update on this? How can I include node_modules dependencies? Thanks!

EDIT: so, I went ahead and submitted a PR to fix this

aldo-roman added a commit to aldo-roman/rollup-plugin-closure-compiler that referenced this issue Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants