wg-performance Status Update 2021-08-16

[erwinmombay]

cc @ampproject/wg-performance

What was accomplished

Lessons Learned

What's Next

[rcebulko]

What was accomplished

• Expanded import/order throughout src/ & 3p/ (♻️ Enable import/order for unlikely-to-conflict src/ subdirs amphtml#35226, ♻️ Enable auto-sorting+grouping within src/ and 3p/ amphtml#35454), test/ & testing/ (🏗 Enable import/order eslint rule in test/ and testing/ amphtml#35601), and most of extensions/ (♻️ Enable import/order on not-recently-updated extensions amphtml#35649)
• Error handling & performance benchmarking for Bento Compiler
• Trimmed getMode() object of version (♻️ Remove version from legacy mode object amphtml#35624), log (♻️ Define helper for hash params and drop barely-used getMode().log amphtml#35628), and geoOverride (♻️ Remove geoOverride from mode amphtml#35654) moving logic to only call-sites
• #core migration of dev error helpers (♻️ #core: error helpers amphtml#35621) and form+modal+amp-element-helpers (♻️ #core form, modal, amp-element-helpers ("real" diff in desc) amphtml#35608)
• Allowlist all #core imports in dep-check-config
• ♻️ Another pass at reducing complexity around Log amphtml#35461
• Fix bug breaking owners bot amp-github-apps#1452

Lessons Learned

What's Next

• Deploy Bento Compiler service for testing
• Finish remaining #core migration
• Explore using tsc for typechecking

[jridgewell]

What was accomplished

• Launched size-adjust experiment: cl/389235307, cl/389746312, cl/389959485
• Fixed forbidden terms linting in test files: Lint for forbidden test terms in test files amphtml#35572
• Integrated rethrowAsync with test expectations: 🏗️ Integrate expectAsyncConsoleError with rethrowAsync amphtml#35605
• Adding type aliases to Babel: Add aliases for Standardized, TypeScript, and Flow babel/babel#13666
• Better minification of switch statements in terser: Optimize various switch statements terser/terser#1044

Lessons Learned

• Switch statements are much more complex than I initially realized. They are not just if-else statements.

What's Next

• Finishing base jolt interpreter evaluation: https://github.com/ampproject/jolt/compare/main...jridgewell:interpreter

[erwinmombay]

amphtml

What was accomplished

• add semi transformed document splitting (in progress cl/387682689)

Lessons Learned

What's Next

• look into reported performance issues in wg-performance
• update amp-geo javascript to handle server side rendering
• finish proposal for external stylesheet experiment for render delay

[samouri]

What was accomplished

• Distribute CSS files with Bento NPM Packages (🖍 ✨ bento npm components: distribute css file amphtml#35446)
• Brought the I2I for migrating off Closure to design review, have a clear set of next steps
• Made ~60% of babel plugins typecheck with tsc (typecheck babel plugins amphtml#35573)
• Created Jolt Bytecode and tests
• Fix LCP/FCP on origin pages: 🐛 performance-impl: origin should use value directly from PO amphtml#35533
• Small refactor to amp-carousel in preparation for creating a buildDom (amp-carousel: Remove BaseSlides amphtml#35500)
• Tests for buildDom! ✅ buildDom: add tests for amp-fit-text and amp-layout amphtml#35494
• ♻️ refactor build-system to use the same codepath for both vendor and unminified builds: 🚀 ♻️ build-system: merge unminified and vendor codepath amphtml#35419

What's Next

• buildDom for amp-carousel
• performance experiment to measure difference in closure and esbuild output
• jolt