Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmChannel's publish callback not invoked on channel error #191

Open
mhr3 opened this issue Sep 30, 2015 · 4 comments
Open

ConfirmChannel's publish callback not invoked on channel error #191

mhr3 opened this issue Sep 30, 2015 · 4 comments

Comments

@mhr3
Copy link

mhr3 commented Sep 30, 2015

It seems that if for example connection to the server is closed, the callback passed to ConfirmChannel.publish() is never invoked. Would be nice if some kind of error was propagated there.

@jwalton
Copy link

jwalton commented Oct 6, 2015

+1 - I'm running into this, too. :(

@jwalton
Copy link

jwalton commented Oct 6, 2015

My test case, in case you're curious - if you connect with a heartbeat, then send a message, then suspend your worker process, wait for RabbitMQ to kill your connection, then resume your process, you never get any kind of error back for the publish.

@Matthew-Davey
Copy link

+1 this is vital for me

@rkaw92
Copy link

rkaw92 commented Jun 27, 2017

Hi, just run into this as well. This behavior should be documented (and visibly), because it seems to be the popular consensus that a callback should always succeed or fail, and never "hang" if an underlying layer is known to have failed. Additionally, waitForConfirms does exactly the same - leaves promises hanging forever. A tutorial / tip should be included, telling users to manually "fail" their outstanding messages.

I find #220 to be relevant as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants