Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative dependency in the parent dir not working #64

Open
xmedeko opened this issue Dec 3, 2019 · 4 comments
Open

Relative dependency in the parent dir not working #64

xmedeko opened this issue Dec 3, 2019 · 4 comments

Comments

@xmedeko
Copy link

xmedeko commented Dec 3, 2019

The Require Module Support works well for the dojo AMD loading. It works even for relative path ./MyModule, but it fails for relative path to the parent dir ../MyModule - e.g. Ctrl + click does not work.

@ptaczek
Copy link

ptaczek commented Oct 7, 2022

Hey there, this seems to be still an issue. Relative paths of dependencies are resolved AGAINST the modulePath from the extension config and therefore pointing to a non-existing file paths.

@anacierdem
Copy link
Owner

This extension should not even work, are you sure it works if the path is not a parent path? I highly doubt it at this point as it is targeting 3-4 years old vscode APIs

@ptaczek
Copy link

ptaczek commented Oct 11, 2022

This extension should not even work, are you sure it works if the path is not a parent path? I highly doubt it at this point as it is targeting 3-4 years old vscode APIs

I am using it on newest VSCode and all I need is to be able to ctrl-click-through to the depemndence module. So I fixed it locally in the ReferenceProvider.js by adding also the '../' pattern to the relative path test and it works as I needed.

@anacierdem
Copy link
Owner

Interesting, that means there is still some hope for the extension :) I can give it another try if I can find the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants