Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro-angular: astro check fails for example in the docs #1013

Open
1 of 2 tasks
jvoigt opened this issue Apr 7, 2024 · 0 comments
Open
1 of 2 tasks

astro-angular: astro check fails for example in the docs #1013

jvoigt opened this issue Apr 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jvoigt
Copy link

jvoigt commented Apr 7, 2024

Please provide the environment you discovered this bug in.

https://github.com/bringbackourneighbours/bbon-poc-astro-analog/blob/main/src/pages/index.astro

Which area/package is the issue in?

astro-angular

Description

When following the example in the docs the app will work as expected both when run astro dev or astro build but astro check will produce an error.

Please provide the exception or error you saw

❯ npm run astro check

> bbon-poc-astro-analog@0.0.1 astro
> astro check

17:30:28 Types generated 1.30s
17:30:28 [check] Getting diagnostics for Astro files in /home/j.voigt/Workspace/bbon/bbon-poc-astro-analog...
src/pages/index.astro:21:34 - error ts(2322): Type '{ "client:visible": true; helpText: string; }' is not assignable to type 'IntrinsicAttributes'.
  Property 'helpText' does not exist on type 'IntrinsicAttributes'.

21   <HelloComponent client:visible helpText="client-binding"/>
                                    ~~~~~~~~
src/pages/index.astro:18:19 - error ts(2322): Type '{ helpText: string; }' is not assignable to type 'IntrinsicAttributes'.
  Property 'helpText' does not exist on type 'IntrinsicAttributes'.

18   <HelloComponent helpText={helpText} />
                     ~~~~~~~~
src/pages/index.astro:17:19 - error ts(2322): Type '{ helpText: string; }' is not assignable to type 'IntrinsicAttributes'.
  Property 'helpText' does not exist on type 'IntrinsicAttributes'.

17   <HelloComponent helpText="Template" />
                     ~~~~~~~~

Result (4 files): 
- 3 errors
- 0 warnings
- 0 hints

Other information

I only had a quick look in the example app and it seems, the astro type checking es not used....
But i have not tried what would happen if we do.

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@jvoigt jvoigt added the bug Something isn't working label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant