Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup prettier and eslint with nx preset @analogjs/platform #980

Open
1 of 2 tasks
d3473r opened this issue Mar 28, 2024 · 1 comment
Open
1 of 2 tasks

Setup prettier and eslint with nx preset @analogjs/platform #980

d3473r opened this issue Mar 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@d3473r
Copy link

d3473r commented Mar 28, 2024

Which scope/s are relevant/related to the feature request?

create-analog

Information

Hi,

I did setup analogjs with nx running the npx create-nx-workspace@latest --preset=@analogjs/platform command.
Now i want to add prettier and eslint to the project, i added a few suggested plugins from eslint, then I'm getting stuck at ESLint couldn't find the plugin "@nx/eslint-plugin-nx".

When i install this dependency I'm getting a peer dependency error, it seems this package was replaced with @nx/eslint-plugin, see: https://github.com/nrwl/nx/blob/master/packages/eslint-plugin/migrations.json

It would be awesome if the @analogjs/platform preset sets up prettier and eslint automatically like the angular-monorepo (npx create-nx-workspace@latest angular-monorepo --preset=angular-monorepo), or the angular-standalone (npx create-nx-workspace@latest myngapp --preset=angular-standalone) presets does.

Describe any alternatives/workarounds you're currently using

Copy the .eslintrc.json and .eslintignore from a nx angular-monorepo and delete the project-dir/.eslintrc.json as this requires the @nx/eslint-plugin-nx plugin

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@d3473r d3473r added the enhancement New feature or request label Mar 28, 2024
@brandonroberts
Copy link
Member

We used to have this functionality included, but Nx removed the ability to use those generators when they introduced support for nx add, so we need to revisit how this works and integrate it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants