-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Added support of workflow artifact's retention policy #398
Conversation
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Hi @kzantow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to see some actual testing added for this
Yes, it makes sense. But it will take some time as I'm not a TS developer and need to improve my skills to write proper testing there. |
@ViacheslavKudinov I think if you just wanted to update the uploadArtifact(name: string, file: string, rootDirectory: string, options: any) {
data.execArgs.env = options
data.artifacts.push({
name: path.basename(name),
file,
} as never);
}, And then in the test check |
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VKMacBookM1Pro.local>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
Signed-off-by: Viacheslav Kudinov <viacheslav.kudinov@gmail.com>
…-input-tuning Updated retention related input and TS code
@ViacheslavKudinov do you mind if I push a few tweaks to this? |
Sure, thanks! |
Signed-off-by: Keith Zantow <kzantow@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for the contribution @ViacheslavKudinov
Vampire/setup-wsl
tov2
http-cache-semantics
to4.1.1
(GHSA-rc47-6667-2j5j)