fix: separate golang license caches from mod dir #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
May 8, 2024
wagoodman
reviewed
May 8, 2024
There was a problem hiding this comment.
This is great! I feel like this is something we can build on over time too.
Since this PR doesn't introduce mechanisms for cache invalidation, users will start to have new cache directories that will continue to grow (this is different than grype, where new DBs get replaced).
I feel like before merging this there should be an answer to how a user would delete the cache or how syft would automatically do this... this could be:
- like you brought up on the call, allow for TTL configuration and track in the cache dir track last write date so we can clean up periodically.
- maybe add a
cache listandcache deletesubcommands to syft
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, license handling in Golang had a few quirks and may not function if the go mod directory did not exist.
This PR makes the following changes:
TODO:
syft /)Fixes: #2798 #1933