Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Upgrade to lit-html 2.0 #22

Open
dflorey opened this issue Oct 29, 2020 · 10 comments
Open

Feature request: Upgrade to lit-html 2.0 #22

dflorey opened this issue Oct 29, 2020 · 10 comments

Comments

@dflorey
Copy link

dflorey commented Oct 29, 2020

...using new Directive class :-)

@christophe-g
Copy link

@andreasbm - just interested to know if this is somehow in a tentative pipeline, now that lit 2.0 is at release candidate stage ?

Thanks a lot, even if the answer is no!

P.S. I am aware that lit now offers localization (https://lit.dev/docs/libraries/localization/), but I prefer lit-translate approach allowing to handle localization files in JSON.

@andreasbm
Copy link
Owner

I'm super excited about the new Directive class! 🌞 I plan on upgrading the library to lit v2 during the next weekend 👍

@christophe-g
Copy link

Oh, that is great - indeed, lit 2 all together is super exciting !

andreasbm added a commit that referenced this issue May 1, 2021
@inureyes
Copy link

👍 Thank you. Looking forward to the release.

@andreasbm
Copy link
Owner

I have now released lit-translate with lit 2 as a release candidate 👍 You can install it with npm i lit-translate@next - when lit 2 is officially released I will release this version as well 🌞

@Mateozmaldonado17
Copy link

Greeat !!! i'm excite for this new version

@mhmo91
Copy link

mhmo91 commented Oct 22, 2021

@andreasbm any updates when this will be a stable release? lit 2 is official now

@jonnenauha
Copy link

jonnenauha commented Feb 2, 2022

Hi @andreasbm any change you could do official 2.0.0 release with the lit v2 branch at some point. I'm getting this warning from webpack duplicate detection plugin.

WARNING in lit
  Multiple versions of lit found:
    2.0.0-rc.2 ./~/lit-translate/~/lit
    2.1.2 ./~/lit

Looks like that branch has dep to "latest" lit. But at the time when you did lit-translate@2.0.0-rc.1 i guess that was lit@2.0.0-rc.2.

The package-lock.json also in that branch has the lit@2.0.0-rc.2 reference.

I'm not too familiar with npm publishing but i would recond you reinstall latest lit so package-lock.json gets fixed to 2.x.x when make official 2.0.0 npm release for lit-translate.

Edit: App build looks to work fine. I think the downside of this is the app is loading lit two times. Once for lit translate and once for everything else. So even if not causing issues it bloats the build unnecessarily.

using npm v8 here is relevant part from my apps lock file

    "node_modules/lit-translate": {
      "version": "2.0.0-rc.1",
      "resolved": "https://registry.npmjs.org/lit-translate/-/lit-translate-2.0.0-rc.1.tgz",
      "integrity": "sha512-8r7MK4OuFoUis41RHS4pFxIuCKn8K/nBdhJKdcnCeD+2MEH0Wg2oiaodYxK6cYcyzc0dFGf1+a/32r4Ym7A/cg==",
      "dependencies": {
        "lit": "2.0.0-rc.2"
      }
    },
    "node_modules/lit-translate/node_modules/lit": {
      "version": "2.0.0-rc.2",
      "resolved": "https://registry.npmjs.org/lit/-/lit-2.0.0-rc.2.tgz",
      "integrity": "sha512-BOCuoJR04WaTV8UqTKk09cNcQA10Aq2LCcBOiHuF7TzWH5RNDsbCBP5QM9sLBSotGTXbDug/gFO08jq6TbyEtw==",
      "dependencies": {
        "@lit/reactive-element": "^1.0.0-rc.2",
        "lit-element": "^3.0.0-rc.2",
        "lit-html": "^2.0.0-rc.3"
      }
    },

@peschee
Copy link

peschee commented Feb 25, 2022

@andreasbm Would you be interested in allowing others to help with the maintenance of this library?

@nicolasr75
Copy link

Shouldn't this issue be closed? I somehow stumbled over this and thought lit-translate would still be on v1 but then fortunately noticed in the releases section that v2 is already out :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants