Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply focus style when focus is made through keyboard navigation #56

Open
gaoryrt opened this issue May 23, 2019 · 4 comments
Open
Labels
feature New feature

Comments

@gaoryrt
Copy link

gaoryrt commented May 23, 2019

the first demo in the document got this problem:
May-23-2019 10-17-57

chrome 75.0.3770.38

@gaoryrt
Copy link
Author

gaoryrt commented May 23, 2019

it also happens in safari, 12.0.3 (14606.4.5)

@andreasbm
Copy link
Owner

Thanks a lot for opening an issue! ☀️The behavior of the switch you are showing in your GIF is actually intended - it is meant to show what element currently has the focus.

But I understand why you don't think this is intended since you are not using a keyboard for navigation. I think it's a great idea to change the default behavior of all focus styles to only be applied when the focus is made through keyboard navigation.

If you agree, I think I'll change the title of your of your issue to something like "Only apply focus style when focus is made through keyboard navigation".

@gaoryrt
Copy link
Author

gaoryrt commented May 24, 2019

Thank you for your explanation, I didn't realize that.

@gaoryrt
Copy link
Author

gaoryrt commented May 24, 2019

That would be great if this feature only triggered through keyboard navigation.

@andreasbm andreasbm added the feature New feature label May 27, 2019
@andreasbm andreasbm changed the title <wl-switch> ripple won‘t disapear after release Only apply focus style when focus is made through keyboard navigation May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants