Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types support for full set of allowed autocomplete values #81

Open
sbryan opened this issue Aug 30, 2019 · 0 comments
Open

Add types support for full set of allowed autocomplete values #81

sbryan opened this issue Aug 30, 2019 · 0 comments

Comments

@sbryan
Copy link

sbryan commented Aug 30, 2019

@property({type: String, reflect: true}) autocomplete?: "on" | "off";

The input behavior class extends the form element behaviors, but, only recognizes "on" or "off" as valid values when in fact, there are many more defined autocompete types/values (see https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete).

For now, this only affects type checking and linting tools that enforce them, but it would be great if this were just a pass-thru attribute to the <input/> element and no errors were flagged on code such as this:

<wl-textfield type="password autocomplete="current-password"></wl-textfield>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant