From 84e4d056ca172c09bf79fe98e9be7c8995c20e06 Mon Sep 17 00:00:00 2001
From: Sam Roberts <vieuxtech@gmail.com>
Date: Fri, 28 Jun 2019 09:36:30 -0700
Subject: [PATCH] test: skip tests related to CI failures on AIX

These tests seem to trigger failures in the entire CI job (not just the
test) on AIX. Skip them to see if that helps alleviate spurious failures
in node-test-commit-aix (and the upstream PR and commit test jobs).

See:
- https://github.com/nodejs/build/issues/1820#issuecomment-505998851
- https://github.com/nodejs/build/issues/1847#issuecomment-504210708

PR-URL: https://github.com/nodejs/node/pull/28469
Backport-PR-URL: https://github.com/nodejs/node/pull/29599
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 .../test-stringbytes-external-exceed-max.js                  | 5 +++++
 test/message/message.status                                  | 3 +++
 test/pseudo-tty/pseudo-tty.status                            | 4 ++++
 test/sequential/sequential.status                            | 3 +++
 4 files changed, 15 insertions(+)

diff --git a/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js b/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
index 319a8a93558c45..87c963e23af20d 100644
--- a/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
+++ b/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
@@ -5,6 +5,11 @@ const skipMessage = 'intensive toString tests due to memory confinements';
 if (!common.enoughTestMem)
   common.skip(skipMessage);
 
+// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
+// See https://github.com/nodejs/node/pull/28469
+if (process.platform === 'aix')
+  common.skip('flaky on AIX');
+
 const binding = require(`./build/${common.buildType}/binding`);
 const assert = require('assert');
 
diff --git a/test/message/message.status b/test/message/message.status
index 1a4a0e3adc2727..d7bd7f48c9faf8 100644
--- a/test/message/message.status
+++ b/test/message/message.status
@@ -16,3 +16,6 @@ prefix message
 
 [$system==freebsd]
 
+[$system==aix]
+# https://github.com/nodejs/node/pull/28469
+vm_dont_display_syntax_error: SKIP
diff --git a/test/pseudo-tty/pseudo-tty.status b/test/pseudo-tty/pseudo-tty.status
index 5c8114692d9447..a945d532fb5937 100644
--- a/test/pseudo-tty/pseudo-tty.status
+++ b/test/pseudo-tty/pseudo-tty.status
@@ -3,6 +3,10 @@ prefix pseudo-tty
 [$system==aix]
 # being investigated under https://github.com/nodejs/node/issues/9728
 test-tty-wrap              : FAIL, PASS
+# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
+# https://github.com/nodejs/node/pull/28469
+console-dumb-tty: SKIP
+test-fatal-error: SKIP
 
 [$system==solaris]
 # https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems
diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status
index 1af493c3a052a6..e4f92aa96bb261 100644
--- a/test/sequential/sequential.status
+++ b/test/sequential/sequential.status
@@ -25,3 +25,6 @@ test-http2-settings-flood: PASS,FLAKY
 [$system==freebsd]
 
 [$system==aix]
+# https://github.com/nodejs/node/pull/28469
+test-async-wrap-getasyncid: SKIP
+test-buffer-creation-regression: SKIP