Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow className prop to apply classes to components #13

Open
Liggi opened this issue Jul 13, 2016 · 5 comments
Open

Allow className prop to apply classes to components #13

Liggi opened this issue Jul 13, 2016 · 5 comments

Comments

@Liggi
Copy link

Liggi commented Jul 13, 2016

At the moment, if you import a component from your CSS, using the className prop to pass global classes in doesn't seem to work.

Is there a way to make these carry through to the underlying markup to allow things like global layout classes?

@andreypopp
Copy link
Owner

Yes, I did that intentionally because I wanted those components to be isolated from global styling.

If I'd change that I'd rather allow extraClassName prop to set a global CSS class name rather than className. That would make an intention explicit and won't make one set className by mistake by passing all props via {...props} syntax.

Up to make a pull request?

@Liggi
Copy link
Author

Liggi commented Jul 14, 2016

Sure! I'll probably get some time to tackle this next week.

@aymericbouzy
Copy link

Is it okay if I make a PR for this issue ?

@andreypopp
Copy link
Owner

@aymericbouzy sure!

@andreypopp
Copy link
Owner

andreypopp commented Mar 16, 2017

@aymericbouzy one thing is that it's probably better to call it className (my prev. suggestion to use extraClassName doesn't look good I think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants