Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Added New screenshot have failed in CI local test #1421

Closed
3 tasks done
Jaehwa-Noh opened this issue May 9, 2024 · 2 comments · May be fixed by #1423
Closed
3 tasks done

[Bug]: Added New screenshot have failed in CI local test #1421

Jaehwa-Noh opened this issue May 9, 2024 · 2 comments · May be fixed by #1423
Labels
bug Something isn't working

Comments

@Jaehwa-Noh
Copy link
Contributor

Jaehwa-Noh commented May 9, 2024 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

Added New screenshot have failed in CI local test #1296

I had added new screenshot for snackbar test on my Mac. See below.
afe53f9

But, the result was failed because of these differences.
Here is the output from CI.

snackbar_expanded_expanded_compare

snackbar_medium_medium_compare

What I'm missing? or What should I do?

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Jaehwa-Noh Jaehwa-Noh added the bug Something isn't working label May 9, 2024
@SimonMarquis
Copy link
Contributor

@Jaehwa-Noh you can let the CI generate them for you. Simply open a PR in your fork, and the CI will automatically commit these files during the build.

@Jaehwa-Noh
Copy link
Contributor Author

Jaehwa-Noh commented May 10, 2024 •
edited

@SimonMarquis Aha, the screenshot tests followed Single-Source-Of-Truth. Good.
I totally understand. Thank you SimonMarquis!

@Jaehwa-Noh Jaehwa-Noh mentioned this issue May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clear instruction at CI screenshot tests error output Jaehwa-Noh/nowinandroid
2 participants
@SimonMarquis @Jaehwa-Noh