Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using MediaCodec PARAMETER_KEY_TUNNEL_PEEK parameters #1169

Open
zubcoco opened this issue Mar 8, 2024 · 2 comments
Open

Using MediaCodec PARAMETER_KEY_TUNNEL_PEEK parameters #1169

zubcoco opened this issue Mar 8, 2024 · 2 comments
Assignees

Comments

@zubcoco
Copy link

zubcoco commented Mar 8, 2024

Currently, when we are using tunneled mode, when we do a seek in pause state, the player could not decode a video frame.
This is not a very good experience for users.

Since Android API level 31, there is a new parameter PARAMETER_KEY_TUNNEL_PEEK. This should fix the actual issue.

Here is the documentation :

Is it planned to add this feature in a future version of media3 to enhance user experience ?

@tonihei
Copy link
Collaborator

tonihei commented Mar 8, 2024

According it its documentation, the default value of the parameter is already "enabled", see https://developer.android.com/reference/android/media/MediaCodec#PARAMETER_KEY_TUNNEL_PEEK (as you linked already). Are you saying that your device is not assuming this parameter is enabled by default?

We may just set the parameter anyway if we cannot rely on the default, given we want this behavior in all cases.

@zubcoco
Copy link
Author

zubcoco commented Mar 11, 2024

It may be usefull to have the possibility to set this parameter.
On different devices, I have always this behavior. The black screen after a seek in pause state.

copybara-service bot pushed a commit that referenced this issue Mar 11, 2024
This should already be the default, but some devices seem
to not adhere to this contract and assume the default is unset.

Issue: #1169
PiperOrigin-RevId: 614697283
copybara-service bot pushed a commit to google/ExoPlayer that referenced this issue Mar 12, 2024
This should already be the default, but some devices seem
to not adhere to this contract and assume the default is unset.

Issue: androidx/media#1169
PiperOrigin-RevId: 614697283
SheenaChhabra pushed a commit that referenced this issue Apr 8, 2024
This should already be the default, but some devices seem
to not adhere to this contract and assume the default is unset.

Issue: #1169
PiperOrigin-RevId: 614697283
(cherry picked from commit cbed80e)
l1068 pushed a commit to l1068org/media that referenced this issue Apr 15, 2024
This should already be the default, but some devices seem
to not adhere to this contract and assume the default is unset.

Issue: androidx#1169
PiperOrigin-RevId: 614697283
(cherry picked from commit cbed80e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants