Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit commented ScriptSharp code when converter cannot handle a given code construct #24

Open
guidoren opened this issue Nov 29, 2016 · 1 comment

Comments

@guidoren
Copy link

guidoren commented Nov 29, 2016

When the converter hits a construct that it cannot translate, it throws errors.
Consider to emit the original source instead as commented code. You can add //TODO: convert this as well.

That way, the result may not be a fully converted TypeScript file, but at least you would have a skeleton to work with.

@andry-tino
Copy link
Owner

andry-tino commented Nov 30, 2016

This will be treated as a MUST for the release of the code converter.

Priority

Due to urgent work to be completed on the ScriptSharp definition generation, this feature will be done after completing the milestone concerning the former.

Effort estimation

Effort should be medium. This feature was not thought of. Impacted areas:

  • AST Walkers and Translation Units are impacted.
  • Design required. Should we do this in ITranslationUnits or in ASTWalkers?
  • Possibility to create a separate component for carrying nodes to output as they are in commented flavor, thus might be possible to restrict this to ASTWalkers only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants