Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type ambiguity with System types #35

Open
andry-tino opened this issue Dec 29, 2016 · 1 comment
Open

Type ambiguity with System types #35

andry-tino opened this issue Dec 29, 2016 · 1 comment

Comments

@andry-tino
Copy link
Owner

andry-tino commented Dec 29, 2016

When translating, it is possible that the source code defines types with the same name as types in MsCoreLib.dll and includes both namespaces, thus generating a clash.

The source code might define an interface:

namespace MyNamespace {
  namespace MySubnamespace {
    public interface INotifyCompletion { }
  }
}

However we have that interface also in MsCoreLibe: System.Runtime.CompilerServices.INotifyCompletion.

Especially when using syntax transformation (which rearranges using directives), we might end up in this situation:

using System.Runtime.CompilerServices;
using MyNamespace.MySubnamespace;

public class MyClass {
  protected INotifyCompletion notifier; // Name clash
}

When processing notifier, the semantic model detects an ambiguity.

@andry-tino
Copy link
Owner Author

To verify, with the new system as per #41, this should not happen

@andry-tino andry-tino moved this from In progress to On hold or blocked in ScriptSharp definition generation Level-0 Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment