Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing? #38

Open
michaelaird opened this issue Feb 24, 2017 · 3 comments
Open

Contributing? #38

michaelaird opened this issue Feb 24, 2017 · 3 comments

Comments

@michaelaird
Copy link

My team and I have been hacking away at adding more conversions for C# features that we used in our Script# projects. We'd like to contribute it back into the main project.

Please have a look at my branch and let me know what you think. There are several things that are still "work in progress" (like handling the case's inside a switch), but we've handled foreach loops, a rough handling of knockout observables and added a naive handling of csproj files.

There are a number of things that we've identified that we need and will try to implement

  • Generics
  • Convert List to x[]
  • Gracefully handle missing "this"
  • Convert delegates to lambdas
  • Allow for namespace instead of module
  • Call "super" in inherited classes
  • and more!
@andry-tino
Copy link
Owner

Hello @michaelaird. Sure thing, nice to have some help. Let me have a better look at your changes.

@michaelaird
Copy link
Author

Great! We're new to using roslyn so feel free to make any "code review" type suggestions on things you think we should do differently.

@andry-tino
Copy link
Owner

Yes! In the meantime, please have a look at the Wiki I just updated in the section Contribute guidelines. The section is still to be expanded, but it has already the basic info required for a good contribution.

I am reviewing the code in the meantime. Get back to you with feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants